Data flow: Restrict public PathNodes to those that may reach a sink#11060
Merged
hvitved merged 4 commits intogithub:mainfrom Nov 4, 2022
Merged
Data flow: Restrict public PathNodes to those that may reach a sink#11060hvitved merged 4 commits intogithub:mainfrom
PathNodes to those that may reach a sink#11060hvitved merged 4 commits intogithub:mainfrom
Conversation
315e92f to
2198eaa
Compare
29 tasks
2198eaa to
edbf7e5
Compare
4dd2747 to
1711efc
Compare
jketema
approved these changes
Nov 3, 2022
Contributor
jketema
left a comment
There was a problem hiding this comment.
C++ expected test output changes 👍
aschackmull
reviewed
Nov 4, 2022
|
|
||
| /** | ||
| * A `Node` augmented with a call context (except for sinks), an access path, and a configuration. | ||
| * Only those `PathNode`s that are reachable from a source, and which can reach a sink, are generated. |
Contributor
There was a problem hiding this comment.
This is not entirely accurate. Nodes that are used in a subpath are also included.
aschackmull
approved these changes
Nov 4, 2022
Contributor
aschackmull
left a comment
There was a problem hiding this comment.
One minor nit re. a qldoc, otherwise LGTM.
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 29, 2022
Merge commit: 587e673
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 29, 2022
Merge commit: 587e673
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 29, 2022
Merge commit: 587e673
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 29, 2022
Merge commit: 587e673
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like
PathNode::getASuccessoris restricted to nodes that can reach a sink, it also makes sense to only expose nodes that can reach a sink. This means that the exposedPathNodeclass and thenodespredicate contain the same elements.The reason for the updated C++ test output is because
DefaultTaintTracking.qlldid not previously restrict thenodesrelation to nodes that can reach a sink.